----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29327/#review67437 -----------------------------------------------------------
src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/29327/#comment111461> This was below 80 chars, was it not? src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/29327/#comment111462> This is isolated and far from the condition that leads to it. Better to invert the condition and put this branch first. Then the method ends with the other return statement and without such an isolated statement. if (state.isNone()) { return Nothing(); } ... the rest ... - Bernd Mathiske On Jan. 6, 2015, 2:14 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29327/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 2:14 p.m.) > > > Review request for mesos, Benjamin Hindman and Bernd Mathiske. > > > Repository: mesos-git > > > Description > ------- > > Add slave id to docker container name prefix. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 28ebc6272cd68167fc9a0898fd8eb9d53890b815 > src/slave/containerizer/docker.cpp 19a6ea2b5342abe4bf10cf4ea2d5d756df9f8665 > > Diff: https://reviews.apache.org/r/29327/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
