----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29327/#review67795 -----------------------------------------------------------
Ship it! src/slave/containerizer/docker.hpp <https://reviews.apache.org/r/29327/#comment111874> Was there any reason to use the '/' as a separator over something else? I'm wondering if the '/' could cause some filesystem path issue if we ever use container names in the filesystem. I assume we don't because I'm assuming this is all tested, but is there any reason not to use a different separator? If we do use the container name for anything path based later we'd have to change the name again and go through another deprecation cycle. Or perhaps a small comment explaining why you chose this separator please, thank you! src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/29327/#comment111873> s/after 0.21.0/starting with 0.22.0/ - Benjamin Hindman On Jan. 6, 2015, 10:14 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29327/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 10:14 p.m.) > > > Review request for mesos, Benjamin Hindman and Bernd Mathiske. > > > Repository: mesos-git > > > Description > ------- > > Add slave id to docker container name prefix. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 28ebc6272cd68167fc9a0898fd8eb9d53890b815 > src/slave/containerizer/docker.cpp 19a6ea2b5342abe4bf10cf4ea2d5d756df9f8665 > > Diff: https://reviews.apache.org/r/29327/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
