----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29785/#review67546 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/29785/#comment111589> Should we be consistent here whether the oprations have single or multiple TaskInfo/Resource? I was +1 for single previously because with the current/desired model it wasn't clear whether to include the entire current/desired state or only the resources that we're operating on. The way it reads now however I think it's clear that only the resources we care about go into these messages. Perhaps we can pluralize all of them? include/mesos/mesos.proto <https://reviews.apache.org/r/29785/#comment111590> Looking at this, it seems a bit unclear to me that we need to put in the target resources rather than the source resources. As a framework author I think I'd be inclined to think that this takes the source resources, since I'm saying "reserve these resources for my role". Alternative approaches here would be: ``` message Reserve { repeated Resource target = 1; } ``` or ``` message Reserve { repeated Resource resources = 1; // If the framework only has a single role, // this can be left unset. optional string role = 2; } ``` - Michael Park On Jan. 9, 2015, 10:56 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29785/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 10:56 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Jie Yu, Michael Park, and > Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > In order to support performing operations against offers (e.g. reserving / > unreserving resources, creating / destroying volumes), this introduces the > notion of an Accept Call, complementary to Decline. > > Launch becomes an alias to an Accept with LaunchTask(s) operations. > > Please take the time to look over this and share your thoughts! > > > Diffs > ----- > > include/mesos/mesos.proto 6c9f5d351bf7befc0a4956d0176018c80d96418d > include/mesos/scheduler/scheduler.proto > 5491c59e7addda0ee5d95a019d7eaeb953ca82e4 > > Diff: https://reviews.apache.org/r/29785/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
