> On Jan. 9, 2015, 11:03 p.m., Jie Yu wrote:
> > include/mesos/mesos.proto, line 624
> > <https://reviews.apache.org/r/29785/diff/1/?file=815287#file815287line624>
> >
> > Why 'RESERVE', not 'RESERVE_RESOURCES'?
>
> Ben Mahler wrote:
> No strong reason, I did this since it's similar to what we do in Decline
> / Accept (we don't call them DeclineOffer / AcceptOffer since OfferIDs are
> inside them) in that we have Resources inside Reserve.
>
> Are you anticipating reserving other types of things?
>
> Jie Yu wrote:
> For consistency, if you use 'reserve' here, I would expect that you use
> Launch (instead of LaunchTask) above:)
Yeah, let me clarify a bit. I originally wanted to have these each as one word:
```
enum Type {
LAUNCH = 1;
RESERVE = 2;
UNRESERVE = 3;
CREATE = 4;
DESTROY = 5;
}
```
vs.
```
enum Type {
LAUNCH_TASKS = 1;
RESERVE_RESOURCES = 2;
UNRESERVE_RESOURCES = 3;
CREATE_VOLUME = 4;
DESTROY_VOLUME = 5;
}
```
Much like the Call / Event types:
```
enum Type {
REGISTERED = 1;
REREGISTERED = 2;
OFFERS = 3;
RESCIND = 4;
UPDATE = 5;
MESSAGE = 6;
FAILURE = 7;
ERROR = 8;
}
enum Type {
REGISTER = 1;
REREGISTER = 2;
UNREGISTER = 3;
REQUEST = 4;
REVIVE = 6;
DECLINE = 5;
ACCEPT = 12;
LAUNCH = 7;
KILL = 8;
ACKNOWLEDGE = 9;
RECONCILE = 10;
MESSAGE = 11;
}
```
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29785/#review67541
-----------------------------------------------------------
On Jan. 9, 2015, 10:56 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29785/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 10:56 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Jie Yu, Michael Park, and
> Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> In order to support performing operations against offers (e.g. reserving /
> unreserving resources, creating / destroying volumes), this introduces the
> notion of an Accept Call, complementary to Decline.
>
> Launch becomes an alias to an Accept with LaunchTask(s) operations.
>
> Please take the time to look over this and share your thoughts!
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 6c9f5d351bf7befc0a4956d0176018c80d96418d
> include/mesos/scheduler/scheduler.proto
> 5491c59e7addda0ee5d95a019d7eaeb953ca82e4
>
> Diff: https://reviews.apache.org/r/29785/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
