----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29781/#review67568 -----------------------------------------------------------
Ship it! Ship It! - Timothy Chen On Jan. 9, 2015, 10:58 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29781/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 10:58 p.m.) > > > Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. > > > Bugs: MESOS-2096 > https://issues.apache.org/jira/browse/MESOS-2096 > > > Repository: mesos-git > > > Description > ------- > > [4/10] Build Mesos Modules outside Mesos source tree. > > This file includes definitions for operators on public protobufs > (defined in mesos.proto) that don't have these operators generated > by the protobuf compiler. The corresponding definitions are in > src/common/type_utils.cpp. > > Mesos modules need some of the protobufs defined in mesos.proto and > require some of these operators declared in type_utils.hpp. Exposing > type_utils.hpp allows us to build modules without having a dependency > on mesos source tree (src/*). > > > Diffs > ----- > > src/Makefile.am 0521f5849acc3237a8fa3970c983beab74441586 > src/cli/execute.cpp 77deec91177c90a8a20ccd4fe063b82ca08cefbd > src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74 > src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 > src/common/type_utils.cpp fcc9eb0e27a9cbf53f7923f0c051a6578527ec37 > src/examples/low_level_scheduler_libprocess.cpp > e5267f7c8da018aaa46de65b85220916fed1b4cf > src/examples/low_level_scheduler_pthread.cpp > 4f9a59401ffe6950a34c1a518d355974e70ac7d2 > src/examples/no_executor_framework.cpp > 5e47cfcfa1677052be114f8a9b0e24f6ef0238d9 > src/examples/test_framework.cpp e5ec3b9f75446980ce9235209b8b74128e3e5e39 > src/exec/exec.cpp e15f834beda94664b8e95c49ea87b4d36b853e71 > src/launcher/executor.cpp 6175bf54d09268feb2007ca5384643adfa00456b > src/log/coordinator.cpp fe0c5f9c55fd7a19b9c85a0860f88dd14205a631 > src/log/recover.cpp 26140654fda5011e89d0081e916a88c9681cd783 > src/log/replica.cpp c18de86f2659b848b0e8f0468e4efa820d048970 > src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8 > src/master/master.hpp 26116aff1e965501c8d94ea0b5bd1be37f944887 > src/master/registrar.cpp 0831963e01e3c87bf0ac27af24b832ab2ae09d97 > src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1 > src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e > src/slave/containerizer/external_containerizer.cpp > efbc68f205b26cff58bc414427d3361711afcc94 > src/slave/containerizer/isolators/cgroups/cpushare.cpp > 90aabb85da452a3a508888f738379a73b7465dc6 > src/slave/containerizer/isolators/cgroups/mem.cpp > 71f4b9b3885ccb1c9e5ad589e65be06045030f19 > src/slave/http.cpp d1cf8a68fab9a2df44f6c753683ad37fd4b1a1f9 > src/slave/monitor.hpp 02b2ce1619c87296ee8c90f6363e77d070dd598d > src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 > src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b > src/slave/state.hpp 592182b21ae2700c627f180db38ca5dc1b3c9e8a > src/slave/status_update_manager.hpp > 1c8a54ea510de084c0f35016e83788d441d3b813 > src/tests/flags.hpp 0d3db6cd13b898674e7e62ce90543c5834225294 > src/tests/protobuf_io_tests.cpp c18bc4f8d342f6a8cbe7ca09fe2bc25f215d8249 > src/tests/registrar_tests.cpp 6bfb679d6ab07143f9c77b8cd9719a36d363645f > src/tests/state_tests.cpp ef2e96fb8b3a5e3b9c3c045b22f43f818d327b9e > > Diff: https://reviews.apache.org/r/29781/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Kapil Arya > >
