-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29781/
-----------------------------------------------------------
(Updated Jan. 13, 2015, 11:55 a.m.)
Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
Changes
-------
Updated include guard for type_utils.hpp. This also fixes the display problem
with reviewboard.
Bugs: MESOS-2096
https://issues.apache.org/jira/browse/MESOS-2096
Repository: mesos-git
Description
-------
[4/10] Build Mesos Modules outside Mesos source tree.
This file includes definitions for operators on public protobufs
(defined in mesos.proto) that don't have these operators generated
by the protobuf compiler. The corresponding definitions are in
src/common/type_utils.cpp.
Mesos modules need some of the protobufs defined in mesos.proto and
require some of these operators declared in type_utils.hpp. Exposing
type_utils.hpp allows us to build modules without having a dependency
on mesos source tree (src/*).
Diffs (updated)
-----
src/Makefile.am fc0c3227466ccf364353a739fec8d9532ea3c683
src/cli/execute.cpp 77deec91177c90a8a20ccd4fe063b82ca08cefbd
src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553
src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000
src/common/type_utils.cpp fcc9eb0e27a9cbf53f7923f0c051a6578527ec37
src/examples/low_level_scheduler_libprocess.cpp
e5267f7c8da018aaa46de65b85220916fed1b4cf
src/examples/low_level_scheduler_pthread.cpp
4f9a59401ffe6950a34c1a518d355974e70ac7d2
src/examples/no_executor_framework.cpp
5e47cfcfa1677052be114f8a9b0e24f6ef0238d9
src/examples/test_framework.cpp e5ec3b9f75446980ce9235209b8b74128e3e5e39
src/exec/exec.cpp aada24664dba9060a92230e25689c89852585443
src/launcher/executor.cpp d527fec3b9e658099571f808aa824bd6e17a6e0d
src/log/coordinator.cpp fe0c5f9c55fd7a19b9c85a0860f88dd14205a631
src/log/recover.cpp 679741b843a1df112090cd2ce2b1bc20abbbcf44
src/log/replica.cpp dedfde4eebc12c6c4d1e75fe1f6751a56324688a
src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
src/master/master.hpp 26116aff1e965501c8d94ea0b5bd1be37f944887
src/master/registrar.cpp 0831963e01e3c87bf0ac27af24b832ab2ae09d97
src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
src/slave/containerizer/external_containerizer.cpp
efbc68f205b26cff58bc414427d3361711afcc94
src/slave/containerizer/isolators/cgroups/cpushare.cpp
90aabb85da452a3a508888f738379a73b7465dc6
src/slave/containerizer/isolators/cgroups/mem.cpp
711d66d7771cac13be831d73af3ef570d6785473
src/slave/http.cpp d1cf8a68fab9a2df44f6c753683ad37fd4b1a1f9
src/slave/monitor.hpp 02b2ce1619c87296ee8c90f6363e77d070dd598d
src/slave/paths.cpp fe951abac1254748dbd5bdd81b7e50da75afad6d
src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6
src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d
src/slave/state.hpp 70777cf6ab681c29ca4df601fe47903e1dbdf41f
src/slave/status_update_manager.hpp 1c8a54ea510de084c0f35016e83788d441d3b813
src/tests/flags.hpp 0d3db6cd13b898674e7e62ce90543c5834225294
src/tests/protobuf_io_tests.cpp c18bc4f8d342f6a8cbe7ca09fe2bc25f215d8249
src/tests/registrar_tests.cpp 6bfb679d6ab07143f9c77b8cd9719a36d363645f
src/tests/state_tests.cpp ef2e96fb8b3a5e3b9c3c045b22f43f818d327b9e
Diff: https://reviews.apache.org/r/29781/diff/
Testing
-------
make check.
Thanks,
Kapil Arya
