----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29869/#review67970 -----------------------------------------------------------
src/master/master.hpp <https://reviews.apache.org/r/29869/#comment112058> Move this to private? src/master/master.cpp <https://reviews.apache.org/r/29869/#comment112059> enclose the framework name inside single quotes. src/master/master.cpp <https://reviews.apache.org/r/29869/#comment112061> We should consider using 'OneOf' protobuf type to get this check for free. https://developers.google.com/protocol-buffers/docs/proto#oneof src/master/master.cpp <https://reviews.apache.org/r/29869/#comment112062> Curious, why you want acceptOffers() call into this method instead of the current way. I imagine each operation to be implemented as a function/method, similar to what you did in Master::call(). - Vinod Kone On Jan. 13, 2015, 11:12 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29869/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 11:12 p.m.) > > > Review request for mesos, Jie Yu, Michael Park, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > This is an initial stub that only handles accepting offers. > > The plan (per the TODO) is to have a single path for launching tasks through > `acceptOffers`, as opposed to `launchTasks`. > > > Diffs > ----- > > src/master/master.hpp 26116aff1e965501c8d94ea0b5bd1be37f944887 > src/master/master.cpp 63ca19ab9618feccd93a2335f9287122a4665c5e > > Diff: https://reviews.apache.org/r/29869/diff/ > > > Testing > ------- > > The code path currently cannot be executed. Tests will be added once the > scheduler driver supports accepting offers. > > make check > > > Thanks, > > Ben Mahler > >
