> On Jan. 13, 2015, 11:59 p.m., Jie Yu wrote: > > src/master/master.cpp, lines 1367-1382 > > <https://reviews.apache.org/r/29869/diff/1/?file=820049#file820049line1367> > > > > I would suggest leaving empty with an Error message here. It'll be > > replaced anyway.
The desire here was to do things incrementally by ensuring that the receive path correctly handles launching tasks, although I can't write tests without the driver changes. :) > On Jan. 13, 2015, 11:59 p.m., Jie Yu wrote: > > src/master/master.cpp, lines 1362-1365 > > <https://reviews.apache.org/r/29869/diff/1/?file=820049#file820049line1362> > > > > Consider s/acceptOffers/call ? Having both the 'accept' parameter and > > 'acceptOffers' in the function name seems to be redundent? Also, using a > > unified name 'call' makes it clear that it's for the new API. Sounds great, plus it's how scheduler.cpp models it's methods. I can't name it `call` cleanly though, given it's the name of the `Call` object. I've named these `receive` instead, which is similar to scheduler.cpp - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29869/#review67976 ----------------------------------------------------------- On Jan. 13, 2015, 11:12 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29869/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 11:12 p.m.) > > > Review request for mesos, Jie Yu, Michael Park, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > This is an initial stub that only handles accepting offers. > > The plan (per the TODO) is to have a single path for launching tasks through > `acceptOffers`, as opposed to `launchTasks`. > > > Diffs > ----- > > src/master/master.hpp 26116aff1e965501c8d94ea0b5bd1be37f944887 > src/master/master.cpp 63ca19ab9618feccd93a2335f9287122a4665c5e > > Diff: https://reviews.apache.org/r/29869/diff/ > > > Testing > ------- > > The code path currently cannot be executed. Tests will be added once the > scheduler driver supports accepting offers. > > make check > > > Thanks, > > Ben Mahler > >
