> On Jan. 14, 2015, 10:10 p.m., Ben Mahler wrote: > > src/authentication/cram_md5/authenticator.hpp, lines 465-480 > > <https://reviews.apache.org/r/29887/diff/2/?file=821731#file821731line465> > > > > What is this fixing? It looks like `initialized` will already gate this > > block of code from being called twice if it succeeds. > > > > Are there multiple threads coming into this? > > > > Would you mind writing a comment that describes the subtlety I'm > > missing? > > Adam B wrote: > initialized gates it once per Authenticator, hence once per master, but > our unit tests spin up multiple masters, and we only want to add/load the > auxprop plugin once per process, even if there are multiple masters. > > Till Toenshoff wrote: > Added this comment above the quoted block: > > // "initialized" will only guard against running this code mutiple > // times within the same instance of the authenticator. The plugin > // however should only get added once per os-process.
@adam: its even worse .. our unit tests keep reusing the same OS process (but not libprocess process), hence it stacks accross tests due to the fact that many tests initialze a master (hence add the aux-prop-plugin again to the same process). - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29887/#review68134 ----------------------------------------------------------- On Jan. 14, 2015, 10:18 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29887/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 10:18 p.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-2050 > https://issues.apache.org/jira/browse/MESOS-2050 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/authentication/cram_md5/authenticator.hpp 1819ef4 > src/authentication/cram_md5/auxprop.hpp b894386 > src/authentication/cram_md5/auxprop.cpp cf503a2 > > Diff: https://reviews.apache.org/r/29887/diff/ > > > Testing > ------- > > make check (with enhanced verbosity, GLOG_v=2 and gtest_repeat=10000) > > > Thanks, > > Till Toenshoff > >
