> On Jan. 14, 2015, 11:19 p.m., Vinod Kone wrote: > > src/authentication/cram_md5/authenticator.hpp, lines 465-480 > > <https://reviews.apache.org/r/29887/diff/2/?file=821731#file821731line465> > > > > I think it's simpler to use 'Once'? > > > > ``` > > static process::Once* auxpropInitialize = new process::Once(); > > static bool auxpropInitialized = false; > > > > if (!auxpropInitialize->once()) { > > ..... > > > > auxpropInitialized = true; > > auxpropInitialize->done(); > > } > > > > if (!auxpropInitialized) { > > return Error("Failed to add \"in-memory\" auxiliary property plugin"); > > } > > > > ```
Yes, thank you. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29887/#review68161 ----------------------------------------------------------- On Jan. 14, 2015, 10:50 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29887/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 10:50 p.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-2050 > https://issues.apache.org/jira/browse/MESOS-2050 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/authentication/cram_md5/authenticator.hpp 1819ef4 > src/authentication/cram_md5/auxprop.hpp b894386 > src/authentication/cram_md5/auxprop.cpp cf503a2 > > Diff: https://reviews.apache.org/r/29887/diff/ > > > Testing > ------- > > make check (with enhanced verbosity, GLOG_v=2 and gtest_repeat=10000) > > > Thanks, > > Till Toenshoff > >
