> On Jan. 17, 2015, 1:39 a.m., Ben Mahler wrote: > > How are we going to manage the duplication across the command executor and > > the docker executor?
I think I'm going to leave them seperate as they most likely will grow independent in tangent. The docker executor is solely responsible for launching docker containers, and have different assumptions. > On Jan. 17, 2015, 1:39 a.m., Ben Mahler wrote: > > src/docker/executor.cpp, lines 50-53 > > <https://reviews.apache.org/r/29329/diff/3/?file=824290#file824290line50> > > > > Just passing by, this says the executor launches the container, but > > below it just looks like it waits for it to terminate via `docker wait`, or > > am I missing something? Ah sorry, I think it's confusing that I later changed the executor to actually launch containers. Somehow I fixed the comment in this commit. > On Jan. 17, 2015, 1:39 a.m., Ben Mahler wrote: > > src/docker/executor.cpp, line 103 > > <https://reviews.apache.org/r/29329/diff/3/?file=824290#file824290line103> > > > > Probably warrants a comment, what does `"exit `...`" do?` This is actually going to removed in a later commit. I posted my whole commit chain. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29329/#review68533 ----------------------------------------------------------- On Jan. 17, 2015, 1:26 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29329/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2015, 1:26 a.m.) > > > Review request for mesos, Benjamin Hindman and Bernd Mathiske. > > > Repository: mesos-git > > > Description > ------- > > Add executor for docker containerizer, replaces the usage of command executor > > > Diffs > ----- > > src/Makefile.am 07bea1f > src/docker/executor.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/29329/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
