----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29976/#review68777 -----------------------------------------------------------
Patch looks great! Reviews applied: [29973, 29974, 29975, 29976] All tests passed. - Mesos ReviewBot On Jan. 20, 2015, 6:49 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29976/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 6:49 p.m.) > > > Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Moved launchTasks logics to ACCEPT call handler in master. > > This patch moves all logics of launchTasks in master to the ACCEPT call > handler in master, and leaves stubs for other offer operations. We still > keeps the launchTasks handler for backwards compatibility. launchTasks will > simply create an Accept call message, and invoke the ACCEPT call handler. > > > Diffs > ----- > > src/master/master.hpp a8ce4d023ddea36cb83a2dc7b95abd12342f345a > src/master/master.cpp e9dcca3c92c94f3123519855e238bcef47eeece9 > src/tests/resource_offers_tests.cpp > d098e7016ac0da7f1d629af099bb1b8fa66da839 > > Diff: https://reviews.apache.org/r/29976/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
