> On Jan. 21, 2015, 1:24 a.m., Vinod Kone wrote: > > src/master/master.cpp, lines 2080-2081 > > <https://reviews.apache.org/r/29976/diff/2/?file=827018#file827018line2080> > > > > s/into a/into/ ? > > > > "offer operation validators use that...", what is "that" ? do you mean > > *some* of those standalone validators?
Revised the comments. > On Jan. 21, 2015, 1:24 a.m., Vinod Kone wrote: > > src/master/master.cpp, line 2871 > > <https://reviews.apache.org/r/29976/diff/2/?file=827018#file827018line2871> > > > > The only weird part about _accept() is that it takes "_authorizations" > > which is specifici to LAUNCH operation. Maybe a comment explaining why it > > had to be done that way? In fact, we may wanna authorize other operations as well in the future:) The accept handler has to be split due to async operations (e.g., authorization) involved. Before doing the async operation, we has to put tasks into pending tasks for reconcile and kill tasks. I'll add a comment. > On Jan. 21, 2015, 1:24 a.m., Vinod Kone wrote: > > src/master/master.cpp, line 2942 > > <https://reviews.apache.org/r/29976/diff/2/?file=827018#file827018line2942> > > > > Lets use this variable when offeredResources are actually being > > validated. Using a separate temp right now is a bit confusing. I have to keep this variable here (above the loop below) because each offer operation might transforms the offered resources. > On Jan. 21, 2015, 1:24 a.m., Vinod Kone wrote: > > src/tests/resource_offers_tests.cpp, lines 556-557 > > <https://reviews.apache.org/r/29976/diff/2/?file=827019#file827019line556> > > > > Any reason to not do this is a subsequent patch? These tests are out of date because creating persistent volumes now needs to be explicitly declared as an operation. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29976/#review68832 ----------------------------------------------------------- On Jan. 20, 2015, 6:49 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29976/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 6:49 p.m.) > > > Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Moved launchTasks logics to ACCEPT call handler in master. > > This patch moves all logics of launchTasks in master to the ACCEPT call > handler in master, and leaves stubs for other offer operations. We still > keeps the launchTasks handler for backwards compatibility. launchTasks will > simply create an Accept call message, and invoke the ACCEPT call handler. > > > Diffs > ----- > > src/master/master.hpp a8ce4d023ddea36cb83a2dc7b95abd12342f345a > src/master/master.cpp e9dcca3c92c94f3123519855e238bcef47eeece9 > src/tests/resource_offers_tests.cpp > d098e7016ac0da7f1d629af099bb1b8fa66da839 > > Diff: https://reviews.apache.org/r/29976/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
