----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30090/#review68786 -----------------------------------------------------------
src/slave/monitor/monitor.hpp <https://reviews.apache.org/r/30090/#comment113236> Should we start using `#pragma once` instead? I have been using that in a different patchset. src/slave/monitor/monitor.hpp <https://reviews.apache.org/r/30090/#comment113239> Is there a reason for not doing a #include for containerizer.hpp and slave/flags.hpp? src/slave/monitor/monitor.hpp <https://reviews.apache.org/r/30090/#comment113240> I don't think modules impose any rule on constructor with/without arguments. The only concern from the point of view of modules is the fact that doing an `bool initialize(...)` allows us to realize failures and we can return a NULL from the `create()` method. If it looks like the initialize() method will never fail (as is the case with this use case), you should feel free to call constructor with arguments. src/slave/monitor/monitor.hpp <https://reviews.apache.org/r/30090/#comment113241> Same as above, use `#pragma once` instead. src/slave/monitor/monitor.cpp <https://reviews.apache.org/r/30090/#comment113242> Rearrange as: ``` #include "slave/flags.hpp" #include "slave/monitor/monitor.hpp" #include "slave/monitor/mesos/monitor.hpp" ``` Since slave/monitor is a subdirectory and so is slave/monitor/mesos src/slave/monitor/monitor.cpp <https://reviews.apache.org/r/30090/#comment113244> Kill this newline? src/slave/monitor/monitor.cpp <https://reviews.apache.org/r/30090/#comment113243> Since it's already a `Try<>` type, can't we just do a `return monitor;` here? - Kapil Arya On Jan. 20, 2015, 4:38 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30090/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 4:38 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2219 > https://issues.apache.org/jira/browse/MESOS-2219 > > > Repository: mesos-git > > > Description > ------- > > Added abstract interface for already existing monitor API. > > > Diffs > ----- > > src/slave/monitor/monitor.hpp PRE-CREATION > src/slave/monitor/monitor.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/30090/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
