> On Jan. 20, 2015, 4:59 p.m., Kapil Arya wrote: > > src/slave/monitor/monitor.hpp, lines 47-53 > > <https://reviews.apache.org/r/30090/diff/1/?file=827306#file827306line47> > > > > I don't think modules impose any rule on constructor with/without > > arguments. The only concern from the point of view of modules is the fact > > that doing an `bool initialize(...)` allows us to realize failures and we > > can return a NULL from the `create()` method. > > > > If it looks like the initialize() method will never fail (as is the > > case with this use case), you should feel free to call constructor with > > arguments.
I misread the code/comments. My comment/issue is not relevant here. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30090/#review68786 ----------------------------------------------------------- On Jan. 20, 2015, 4:38 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30090/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 4:38 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2219 > https://issues.apache.org/jira/browse/MESOS-2219 > > > Repository: mesos-git > > > Description > ------- > > Added abstract interface for already existing monitor API. > > > Diffs > ----- > > src/slave/monitor/monitor.hpp PRE-CREATION > src/slave/monitor/monitor.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/30090/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
