----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30091/#review68790 -----------------------------------------------------------
Mostly a style review :-). src/slave/monitor.hpp <https://reviews.apache.org/r/30091/#comment113248> `#pragma once`? src/slave/monitor.hpp <https://reviews.apache.org/r/30091/#comment113249> Sort please :-). src/slave/monitor.hpp <https://reviews.apache.org/r/30091/#comment113250> Can't we just do a `#include ".../containerizer.hpp"` here? src/slave/monitor.cpp <https://reviews.apache.org/r/30091/#comment113253> Sort as per the comment in the parent RR :-). src/slave/monitor.cpp <https://reviews.apache.org/r/30091/#comment113259> Likewise. CHECK_NOTNULL(process) src/slave/monitor.cpp <https://reviews.apache.org/r/30091/#comment113256> CHECK_NOTNULL(process) instead? src/slave/monitor.cpp <https://reviews.apache.org/r/30091/#comment113258> Same as above -- CHECK_NOTNULL(process). - Kapil Arya On Jan. 20, 2015, 4:38 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30091/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 4:38 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2219 > https://issues.apache.org/jira/browse/MESOS-2219 > > > Repository: mesos-git > > > Description > ------- > > Moved existing monitor implementation to src/slave/monitor/mesos/ similar to > containerizer structure. > > > Diffs > ----- > > src/slave/monitor.hpp f4ebafc5bbba43669dc1436899072b009936a22e > src/slave/monitor.cpp 398af010564e999b46e38560ba1e652261a9420c > > Diff: https://reviews.apache.org/r/30091/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
