> On Jan. 20, 2015, 2:19 p.m., Kapil Arya wrote: > > src/slave/monitor.hpp, lines 19-20 > > <https://reviews.apache.org/r/30091/diff/1/?file=827308#file827308line19> > > > > `#pragma once`?
We don't have consensus yet on pragma once, so will drop for now (and reopen if we get to a conclusion before this goes in). > On Jan. 20, 2015, 2:19 p.m., Kapil Arya wrote: > > src/slave/monitor.cpp, lines 39-41 > > <https://reviews.apache.org/r/30091/diff/1/?file=827309#file827309line39> > > > > Sort as per the comment in the parent RR :-). We still don't have a consistent way of separating subdirectory includes. Can you point to a reference to this rule? > On Jan. 20, 2015, 2:19 p.m., Kapil Arya wrote: > > src/slave/monitor.cpp, line 295 > > <https://reviews.apache.org/r/30091/diff/1/?file=827309#file827309line295> > > > > Likewise. CHECK_NOTNULL(process) The return value of CHECK_NOTNULL() is not a stream but the pointer (if present). For example: Foo* foobar = NULL; CHECK_NOTNULL(foobar)->baz(qux); > On Jan. 20, 2015, 2:19 p.m., Kapil Arya wrote: > > src/slave/monitor.hpp, line 50 > > <https://reviews.apache.org/r/30091/diff/1/?file=827308#file827308line50> > > > > Can't we just do a `#include ".../containerizer.hpp"` here? We sure can - fixed. - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30091/#review68790 ----------------------------------------------------------- On Jan. 21, 2015, 5:03 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30091/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 5:03 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2219 > https://issues.apache.org/jira/browse/MESOS-2219 > > > Repository: mesos-git > > > Description > ------- > > Added resource monitor interface and moved existing monitor implementation to > src/slave/monitor/mesos/ similar to containerizer structure. > > > Diffs > ----- > > src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e > src/slave/monitor.hpp f4ebafc5bbba43669dc1436899072b009936a22e > src/slave/monitor.cpp 398af010564e999b46e38560ba1e652261a9420c > src/slave/monitor/monitor.hpp PRE-CREATION > src/slave/monitor/monitor.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/30091/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
