> On Jan. 5, 2015, 7:23 a.m., Adam B wrote: > > 3rdparty/libprocess/include/process/future.hpp, lines 1499-1500 > > <https://reviews.apache.org/r/29535/diff/1/?file=805390#file805390line1499> > > > > Any reason why internal::repair places the lambda parameter before the > > promise, and internal::thenf reverses the order?
Made them all be consistent. For posterity, I've been making the continuations take the arguments that the previous function had first, followed by any new arguments created. This should make the conversions to lambda even easier. > On Jan. 5, 2015, 7:23 a.m., Adam B wrote: > > 3rdparty/libprocess/include/process/future.hpp, lines 1597-1600 > > <https://reviews.apache.org/r/29535/diff/1/?file=805390#file805390line1597> > > > > Maybe worth making a private helper function here, since it's already > > repeated so many times. But it's small and an explicit bit of code, I'd hate to lose that in a helper that people don't remember what it does. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29535/#review66600 ----------------------------------------------------------- On Jan. 21, 2015, 5:47 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29535/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 5:47 p.m.) > > > Review request for mesos and Adam B. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > 0326b23cdd475c6e86b33f9b4c63136fdecab443 > 3rdparty/libprocess/src/tests/process_tests.cpp > 3bbfe0a7a65acb52d139fda81816acf305d891f5 > > Diff: https://reviews.apache.org/r/29535/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
