----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29535/#review68983 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/src/tests/process_tests.cpp <https://reviews.apache.org/r/29535/#comment113550> You could be more explicit in commenting how you're testing that the 'repair' callback doesn't get executed. I'm assuming it's because you actually get back the 42 you set, rather than the 43 from repair, but it's not super obvious. - Adam B On Jan. 21, 2015, 9:47 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29535/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 9:47 a.m.) > > > Review request for mesos and Adam B. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > 0326b23cdd475c6e86b33f9b4c63136fdecab443 > 3rdparty/libprocess/src/tests/process_tests.cpp > 3bbfe0a7a65acb52d139fda81816acf305d891f5 > > Diff: https://reviews.apache.org/r/29535/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
