----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29603/#review69465 -----------------------------------------------------------
Ship it! src/module/isolator.hpp <https://reviews.apache.org/r/29603/#comment114170> Insert blank line please. - Till Toenshoff On Jan. 22, 2015, 1:18 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29603/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 1:18 a.m.) > > > Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. > > > Bugs: MESOS-2096 > https://issues.apache.org/jira/browse/MESOS-2096 > > > Repository: mesos-git > > > Description > ------- > > [7/10] Build Mesos Modules outside Mesos source tree. > > Expose "slave/state.hpp" and "slave/containerizer/isolator.hpp" to allow > modules to include them directly from the Mesos install location. > > > Diffs > ----- > > src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e > src/examples/test_isolator_module.cpp > dc107a1315271b0275c60819c4b5aaa1f527e73c > src/exec/exec.cpp aada24664dba9060a92230e25689c89852585443 > src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8 > src/slave/containerizer/composing.cpp > a6ae817a973d49b433519beb8eda99692c203613 > src/slave/containerizer/containerizer.hpp > 129e60f20835f5d151701e934330b81825887af1 > src/slave/containerizer/containerizer.cpp > 421bb868b353e644578fa27f04bdd636bfc89134 > src/slave/containerizer/external_containerizer.hpp > 8363cec490a2918e08a8d30d9b8832fd1e2dd4f5 > src/slave/containerizer/isolator.hpp > a27c3e955ff25b87599af0ac2c97427a88b786f6 > src/slave/containerizer/isolator.cpp > 90a47c4fc8ce2d1a2aa09fa9ad905b76eab74c80 > src/slave/containerizer/isolators/cgroups/cpushare.hpp > 4ded0c4678ad61742a69e14233006a448f3fc3ca > src/slave/containerizer/isolators/cgroups/mem.hpp > 2fa755571b4d21b8b13301fcfd57ae05ea66e6e6 > src/slave/containerizer/isolators/cgroups/perf_event.hpp > e511c3efe4cc4ec13cc74bdcda993477a4db2e36 > src/slave/containerizer/isolators/filesystem/shared.hpp > 727f63e16fa69293c472a4b6b95fb0be04e689c8 > src/slave/containerizer/isolators/namespaces/pid.hpp > 8da6cccff04edf11fa37f5a33648821299cf49d5 > src/slave/containerizer/isolators/network/port_mapping.hpp > f1e23526bc18b23f187c5d38e63d366cb509fff0 > src/slave/containerizer/isolators/posix.hpp > 7a667e3e30712b98484947520b58965d3b768659 > src/slave/containerizer/isolators/posix/disk.hpp > cf4e143eb50cf5ee59ca0d47dd6f8d0a845c3732 > src/slave/containerizer/launcher.hpp > 18b3546a5e51e8a3819bca11630f699a0aadf762 > src/slave/containerizer/mesos/containerizer.hpp > 802988c90ac872b0cefa5e28f06e6fec98e8d032 > src/slave/containerizer/mesos/containerizer.cpp > d712278428889ebdfd598537690138329d8464f0 > src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 > src/slave/slave.cpp fca83b3977b95ddda30f9830da10e124b5c605e6 > src/slave/state.hpp 70777cf6ab681c29ca4df601fe47903e1dbdf41f > src/slave/state.cpp a36fa53099300ee03f051b0f5eaaafe9f1da68d1 > src/slave/status_update_manager.hpp > 1c8a54ea510de084c0f35016e83788d441d3b813 > src/slave/status_update_manager.cpp > fab8c22d46b8ab0a3c3745541ddc650b574bfbd4 > src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 > src/tests/containerizer_tests.cpp cfe31a6b528ec44c5f4ff9eaf453c68d9e518db4 > src/tests/docker_containerizer_tests.cpp > 2105ae2c410f01e7e0d10241d5c00df143fd3439 > src/tests/isolator.hpp 2c3a694fade996df6fb679e78f96876a7d32d214 > src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 > src/tests/module.cpp e6dbf94e97dbad46e25c0e4fc79dcbb8c56e5acd > src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc > src/tests/paths_tests.cpp 417aa51b99d54055ad7254b4f274fb59d0794ca6 > src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca > src/tests/slave_recovery_tests.cpp 809822e63b05a21418cd9297c927d656d6fd871d > src/tests/status_update_manager_tests.cpp > 6ff732020d17d5339c8f03412c3b00a2c2ca8357 > > Diff: https://reviews.apache.org/r/29603/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Kapil Arya > >
