> On Jan. 27, 2015, 8:14 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp, lines 190-223 > > <https://reviews.apache.org/r/29288/diff/10/?file=836988#file836988line190> > > > > Can you check the indentation here?
the lines are over 80 charachters, how should I split them ? > On Jan. 27, 2015, 8:14 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 853 > > <https://reviews.apache.org/r/29288/diff/10/?file=836987#file836987line853> > > > > Fix indentation. the line is over 80 charachters, how should I split it ? > On Jan. 27, 2015, 8:14 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp, line 165 > > <https://reviews.apache.org/r/29288/diff/10/?file=836988#file836988line165> > > > > Can you check the indentation on this? the line is over 80 charachters, how should I split it ? > On Jan. 27, 2015, 8:14 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp, line 174 > > <https://reviews.apache.org/r/29288/diff/10/?file=836988#file836988line174> > > > > indentation. same here > On Jan. 27, 2015, 8:14 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp, line 186 > > <https://reviews.apache.org/r/29288/diff/10/?file=836988#file836988line186> > > > > Indentation. same here. - Evelina ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29288/#review69856 ----------------------------------------------------------- On Jan. 27, 2015, 4:58 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29288/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 4:58 p.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van > Remoortere, and Niklas Nielsen. > > > Bugs: MESOS-1919 > https://issues.apache.org/jira/browse/MESOS-1919 > > > Repository: mesos-git > > > Description > ------- > > Created the inner class InAddrStorage encapsulated inside the IP class. > The class uses a union with the in_addr and in6_addr fields. > I considered that the The MasterInfo protobuffers should have both an ipv4 > and an ipv6 field. > I intend to use the same Classifiers, addition, removal and update of > container filters, but write different encode/decode functions for IPv4/ICMP > and IPv6/ICMPv6 because the processing of the protocol headers differ. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > a0210ea6440086246aafe632f86498abbb70719a > 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp > 425132e5d7c3770be4a5a39feea5a2f22179b871 > > Diff: https://reviews.apache.org/r/29288/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
