> On Jan. 28, 2015, 6:51 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 400 > > <https://reviews.apache.org/r/29288/diff/13/?file=838809#file838809line400> > > > > please drop the : > > > > explicit InternetAddress(const ...) > > : family_(AF_INET) > > { > > }
I think this should be left as it is. For example, this is consistent with the IP constructor. > On Jan. 28, 2015, 6:51 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 709 > > <https://reviews.apache.org/r/29288/diff/13/?file=838809#file838809line709> > > > > default case with error added an ABORT. > On Jan. 28, 2015, 6:51 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 565 > > <https://reviews.apache.org/r/29288/diff/13/?file=838809#file838809line565> > > > > static Try<IP> fromAddressNetmask( > > const InternetAddress& address, > > const InternetAddress& netmask); > > > > I think this is more consistent with the code-base? done. > On Jan. 28, 2015, 6:51 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 483 > > <https://reviews.apache.org/r/29288/diff/13/?file=838809#file838809line483> > > > > can you add a TODO to work towards removing these calls? Ideally > > nothing outside should need the stored internal addresses. we will still need them (eg : for container isolation, we will need to do that for a specific family type). > On Jan. 28, 2015, 6:51 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 383 > > <https://reviews.apache.org/r/29288/diff/13/?file=838809#file838809line383> > > > > Represents an IP address. done - Evelina ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29288/#review70042 ----------------------------------------------------------- On Jan. 28, 2015, 8:14 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29288/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2015, 8:14 p.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van > Remoortere, and Niklas Nielsen. > > > Bugs: MESOS-1919 > https://issues.apache.org/jira/browse/MESOS-1919 > > > Repository: mesos-git > > > Description > ------- > > Created the inner class InAddrStorage encapsulated inside the IP class. > The class uses a union with the in_addr and in6_addr fields. > I considered that the The MasterInfo protobuffers should have both an ipv4 > and an ipv6 field. > I intend to use the same Classifiers, addition, removal and update of > container filters, but write different encode/decode functions for IPv4/ICMP > and IPv6/ICMPv6 because the processing of the protocol headers differ. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > a0210ea6440086246aafe632f86498abbb70719a > 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp > 425132e5d7c3770be4a5a39feea5a2f22179b871 > > Diff: https://reviews.apache.org/r/29288/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
