> On Feb. 11, 2015, 5:57 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 392 > > <https://reviews.apache.org/r/29288/diff/19/?file=860854#file860854line392> > > > > if this is accepted, the method is poorly named as it's not 'decimal' > > any more. > > > > i don't know the 'right' name for this :/
I think fromDecimal it's ok. For IPv6 the notation is called "colon hexadecimal" and for IPv4 "dot decimal". > On Feb. 11, 2015, 5:57 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 405 > > <https://reviews.apache.org/r/29288/diff/19/?file=860854#file860854line405> > > > > s/InternetAddress/IP thanks for that > On Feb. 11, 2015, 5:57 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 625 > > <https://reviews.apache.org/r/29288/diff/19/?file=860854#file860854line625> > > > > unnecessary comment removed > On Feb. 11, 2015, 5:57 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 626 > > <https://reviews.apache.org/r/29288/diff/19/?file=860854#file860854line626> > > > > actually, all of these constructors and operators seem redundant. it's > > perfectly reasonable for the outer IP class to work with the internals of > > the union directly. removed them, although I think that the comparison operators should have been left. > On Feb. 11, 2015, 5:57 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 634 > > <https://reviews.apache.org/r/29288/diff/19/?file=860854#file860854line634> > > > > never ever do this. you'll wipe any vtables that get set up. > > > > just explicitly initialize every member in the constructor initializer > > list. didn't know that. - Evelina ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29288/#review71977 ----------------------------------------------------------- On Feb. 12, 2015, 5:47 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29288/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2015, 5:47 p.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van > Remoortere, and Niklas Nielsen. > > > Bugs: MESOS-1919 > https://issues.apache.org/jira/browse/MESOS-1919 > > > Repository: mesos > > > Description > ------- > > Created the inner class InAddrStorage encapsulated inside the IP class. > The class uses a union with the in_addr and in6_addr fields. > I considered that the The MasterInfo protobuffers should have both an ipv4 > and an ipv6 field. > I intend to use the same Classifiers, addition, removal and update of > container filters, but write different encode/decode functions for IPv4/ICMP > and IPv6/ICMPv6 because the processing of the protocol headers differ. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > a0210ea6440086246aafe632f86498abbb70719a > 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp > 425132e5d7c3770be4a5a39feea5a2f22179b871 > > Diff: https://reviews.apache.org/r/29288/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
