----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30394/#review70206 -----------------------------------------------------------
src/etcd/url.hpp <https://reviews.apache.org/r/30394/#comment115276> `#include <iostream>` or, what I would prefer `#include <iosfwd>` and move `operator<<` definitions into `url.cpp` src/etcd/url.hpp <https://reviews.apache.org/r/30394/#comment115277> Empty line, please! src/etcd/url.hpp <https://reviews.apache.org/r/30394/#comment115281> You store the path with the leading `/`, could you please reflect it here? src/etcd/url.hpp <https://reviews.apache.org/r/30394/#comment115278> Maybe it makes sense to kill `public:` or s/struct/class/? src/etcd/url.hpp <https://reviews.apache.org/r/30394/#comment115273> s/strm/stream/ ; Stick & to the type, please. src/etcd/url.cpp <https://reviews.apache.org/r/30394/#comment115280> Shouldn't we add `<cassert>`? src/etcd/url.cpp <https://reviews.apache.org/r/30394/#comment115279> Kill one line, please src/etcd/url.cpp <https://reviews.apache.org/r/30394/#comment115283> Though I like range-based for loops, I don't think we have agreed to start using them (FWIK we still support archaic GCC). I think we use `foreach` in such cases. src/etcd/url.cpp <https://reviews.apache.org/r/30394/#comment115284> Extra newline. - Alexander Rukletsov On Jan. 29, 2015, 3:58 a.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30394/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 3:58 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1806 > https://issues.apache.org/jira/browse/MESOS-1806 > > > Repository: mesos-git > > > Description > ------- > > etcd api wrapper > > > Diffs > ----- > > src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e > src/etcd/etcd.hpp PRE-CREATION > src/etcd/etcd.cpp PRE-CREATION > src/etcd/url.hpp PRE-CREATION > src/etcd/url.cpp PRE-CREATION > src/master/constants.hpp c386eab3973363e64c113f7e84452456fdd3393c > src/master/constants.cpp 9ee17e9ad884da98cabfdfe316cb4a831de193b3 > > Diff: https://reviews.apache.org/r/30394/diff/ > > > Testing > ------- > > > Thanks, > > Cody Maloney > >
