----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30394/#review70210 -----------------------------------------------------------
Sorry for this second part, think of it as a continuation : ). src/etcd/etcd.cpp <https://reviews.apache.org/r/30394/#comment115288> What is `::URL`? src/etcd/etcd.cpp <https://reviews.apache.org/r/30394/#comment115289> Let's move `URL etcd_url` to a new line and allign accordingly. Also, I think we use camelCase everywhere, so maybe `etcdURL` is a better name. src/etcd/etcd.cpp <https://reviews.apache.org/r/30394/#comment115292> Could you please point me to `http::put()` definition? src/etcd/etcd.cpp <https://reviews.apache.org/r/30394/#comment115293> See above, where does `http::get()` live? - Alexander Rukletsov On Jan. 29, 2015, 3:58 a.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30394/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 3:58 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1806 > https://issues.apache.org/jira/browse/MESOS-1806 > > > Repository: mesos-git > > > Description > ------- > > etcd api wrapper > > > Diffs > ----- > > src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e > src/etcd/etcd.hpp PRE-CREATION > src/etcd/etcd.cpp PRE-CREATION > src/etcd/url.hpp PRE-CREATION > src/etcd/url.cpp PRE-CREATION > src/master/constants.hpp c386eab3973363e64c113f7e84452456fdd3393c > src/master/constants.cpp 9ee17e9ad884da98cabfdfe316cb4a831de193b3 > > Diff: https://reviews.apache.org/r/30394/diff/ > > > Testing > ------- > > > Thanks, > > Cody Maloney > >
