----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30386/#review70144 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/30386/#comment115145> Nice :) Do you need to pass the slave here? Can you remove it for now? src/master/master.cpp <https://reviews.apache.org/r/30386/#comment115319> Since we have to still check uniqueness across 'Resources', could we handle uniqueness through the ResourceUsage checker? To be specific, having 2 IDs inside a task / executor will mean that it's using more resources than we've offered. For create operations, we are interested in looking at duplicates within what is being created and compared to what's in the slave. If there's something I'm missing, we could still keep this but split it into two validators: (1) PersistenceIDValidator -> For tasks, makes sure no duplicates. (2) PersistenceIDCreationValidator -> For CREATE, makes sure it hasn't already been created. For launch, we use (1), and for create we use (1) and (2). Thoughts? src/master/master.cpp <https://reviews.apache.org/r/30386/#comment115322> Any reason these checks captured in Validators? src/master/master.cpp <https://reviews.apache.org/r/30386/#comment115320> What is this TODO? How could one create a volume that's already reserved? - Ben Mahler On Jan. 29, 2015, 12:12 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30386/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 12:12 a.m.) > > > Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Added support for CREATE operation in master. > > > Diffs > ----- > > src/master/master.hpp 1d342e56116ad63aade43484b6899ce26f25abfd > src/master/master.cpp 54f26900ac8c63e79a1f89562a988c9a2567d209 > > Diff: https://reviews.apache.org/r/30386/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
