> On Feb. 4, 2015, 8:56 p.m., Ben Mahler wrote: > > src/master/master.cpp, line 1348 > > <https://reviews.apache.org/r/30386/diff/2/?file=846897#file846897line1348> > > > > Maybe we should add a little note there that there is no direct > > feedback to the framework when an operation is dropped, they will find out > > that the operation was dropped through subsequent offers.
Added a note. > On Feb. 4, 2015, 8:56 p.m., Ben Mahler wrote: > > src/master/master.cpp, lines 4610-4613 > > <https://reviews.apache.org/r/30386/diff/2/?file=846897#file846897line4610> > > > > Are you planning to keep this variable? Seems like every operation will > > require checkpointing for now, hence the name of the method being > > `updateCheckpointedResource`? :) Killed and use CHECK in default case. > On Feb. 4, 2015, 8:56 p.m., Ben Mahler wrote: > > src/master/master.cpp, lines 4616-4627 > > <https://reviews.apache.org/r/30386/diff/2/?file=846897#file846897line4616> > > > > Hm.. seems like this method should enforce that the operation type is > > supported (via CHECK or LOG(FATAL))? The caller is expected not to call > > this with anything that might get dropped in here, right? Yes, add LOG(FATAL) in the default case. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30386/#review71040 ----------------------------------------------------------- On Feb. 4, 2015, 1:09 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30386/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 1:09 a.m.) > > > Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added support for CREATE operation in master. > > > Diffs > ----- > > src/master/master.hpp cd37ee9d3c57bcd91f08cd402ec1e4a09d9e42ee > src/master/master.cpp d04b2c4041d8fe8978b877f07579a6f907903e1b > > Diff: https://reviews.apache.org/r/30386/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
