> On Jan. 22, 2015, 11:28 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/url.hpp, line 88 > > <https://reviews.apache.org/r/29533/diff/2/?file=828482#file828482line88> > > > > Is there any less painful way to do this? It seems rather round-about / > > in-efficient. (Constructing a vector of strings, then a giant string, and > > then appending that to a stringstream. > > > > I know we're trying to cleanly truncate one '&' character. > > > > For example, if we had an overload for std::pair<T, T> in stringify, > > then we could pass the hashmap to the string::join('&', url.query) function. > > > > We might also want to support a strings::join for iterable that appends > > to the stream (like the templated version does) as opposed to constring a > > string and then streaming that out again.
I'm going to pull in Cody's changes and then fix this! > On Jan. 22, 2015, 11:28 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/url.hpp, line 82 > > <https://reviews.apache.org/r/29533/diff/2/?file=828482#file828482line82> > > > > Do we have a policy around using single quotes for single character > > literals? ':' instead of ":" No policy, but for consistency I've always just used quotes. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29533/#review69295 ----------------------------------------------------------- On Jan. 21, 2015, 5:44 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29533/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 5:44 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-incubating > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 8e51957d141af0be64cac42f65e03bca5929c8a9 > 3rdparty/libprocess/3rdparty/stout/include/stout/url.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/url_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/29533/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
