> On Jan. 28, 2015, 6:17 p.m., Niklas Nielsen wrote: > > src/slave/http.cpp, line 274 > > <https://reviews.apache.org/r/30074/diff/3/?file=828308#file828308line274> > > > > We should think about how to get the fact in, that it integer is a > > number of seconds. > > > > How about something like: > > > > max_allowed_directory_age_seconds = 42 > > or > > max_allowed_directory_seconds = 42 > > > > ? > > Alexander Rojas wrote: > Yeah, I was wondering about that too, I like that idea too. Too keep it > consistant with > https://github.com/apache/mesos/blob/master/src/slave/metrics.cpp#L35 I will > use the `_secs` prefix
Feel free to drop this, but I do not like `_secs` prefix. There is no [such unit in SI](https://en.wikipedia.org/wiki/SI_base_unit#The_seven_SI_base_units). Note that we also use `_seconds` postfix. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30074/#review70029 ----------------------------------------------------------- On Feb. 4, 2015, 3:40 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30074/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 3:40 p.m.) > > > Review request for mesos, Niklas Nielsen and Till Toenshoff. > > > Bugs: mesos-2229 > https://issues.apache.org/jira/browse/mesos-2229 > > > Repository: mesos > > > Description > ------- > > Adds and entry `max_allowed_age` to the response of the stats.json endpoint > in the slave. The format of the value is `{double}(days|mins|secs)`. > > The max allowed age value is available only if it is set, which depends on > the flag `--disk_watch_interval` which by default runs every minute (So it > will only be available after the first minute running). > > Modifies the unit test `SlaveTest.MetricsInStatsEndpoint` so it takes into > account the new entry. > > > Diffs > ----- > > src/slave/http.cpp 0395d00 > src/slave/slave.hpp 70bd8c1 > src/slave/slave.cpp a8b2621 > src/tests/slave_tests.cpp e7e2af6 > > Diff: https://reviews.apache.org/r/30074/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
