> On Jan. 21, 2015, 2:29 a.m., Sunil Abraham wrote: > > I think the stats.json endpoint should report the max allowed age in type > > `double` not `double string`, to keep the stats.json key:value type as > > `string`:`double`. This could be achieved by having the value be either in > > seconds or milliseconds.
I like the idea on principle, but then it comes the question of how to make the units obvious. One example would be to have the name be something like `max_allowed_age_s` or `max_allowed_age_ms`. Another option to document somewhere with big letters the unit system, or (and I don't know about it) keep all units the same. I like the last one the most, but I don't know if we do that already. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30074/#review68848 ----------------------------------------------------------- On Jan. 21, 2015, 10:23 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30074/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 10:23 a.m.) > > > Review request for mesos, Niklas Nielsen and Till Toenshoff. > > > Bugs: mesos-2229 > https://issues.apache.org/jira/browse/mesos-2229 > > > Repository: mesos-git > > > Description > ------- > > Adds and entry `max_allowed_age` to the response of the stats.json endpoint > in the slave. The format of the value is `{double}(days|mins|secs)`. > > The max allowed age value is available only if it is set, which depends on > the flag `--disk_watch_interval` which by default runs every minute (So it > will only be available after the first minute running). > > Modifies the unit test `SlaveTest.MetricsInStatsEndpoint` so it takes into > account the new entry. > > > Diffs > ----- > > src/slave/http.cpp d1cf8a6 > src/slave/slave.hpp 70bd8c1 > src/slave/slave.cpp fca83b3 > src/tests/slave_tests.cpp a85a028 > > Diff: https://reviews.apache.org/r/30074/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
