----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30596/#review71058 -----------------------------------------------------------
Patch looks great! Reviews applied: [30579, 30580, 30583, 30595, 30596] All tests passed. - Mesos ReviewBot On Feb. 4, 2015, 2:14 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30596/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 2:14 a.m.) > > > Review request for mesos, Alexander Rukletsov, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2228 > https://issues.apache.org/jira/browse/MESOS-2228 > > > Repository: mesos > > > Description > ------- > > This ensures the slave can see the TaskInfo.command.grace_period_seconds > inside the ExecutorInfo, when setting up the shutdown timeout. > > > Diffs > ----- > > src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b > > Diff: https://reviews.apache.org/r/30596/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >