----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30596/#review71064 -----------------------------------------------------------
Ship it! It would be easier to follow you change if you could bring in the removal of updateGracePeriod() in this patch :) src/slave/slave.cpp <https://reviews.apache.org/r/30596/#comment116670> It could be here you ensured that the executor info has a timeout (set from the slave flags value if absent) :) - Niklas Nielsen On Feb. 3, 2015, 6:14 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30596/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 6:14 p.m.) > > > Review request for mesos, Alexander Rukletsov, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2228 > https://issues.apache.org/jira/browse/MESOS-2228 > > > Repository: mesos > > > Description > ------- > > This ensures the slave can see the TaskInfo.command.grace_period_seconds > inside the ExecutorInfo, when setting up the shutdown timeout. > > > Diffs > ----- > > src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b > > Diff: https://reviews.apache.org/r/30596/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
