> On Feb. 4, 2015, 7:02 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, lines 601-603 > > <https://reviews.apache.org/r/30612/diff/2/?file=847632#file847632line601> > > > > Shouldn't it be `/frameworks.json`? > > Alexander Rojas wrote: > This is a good question. On principle, I agree with you, but the route is > more than frameworks, and using the `.json` suffix would requiere then manual > of the path or having something like `/frameworks.json/{whatever-comes-next}`
So this was discussed this with nnielsen and at the end it boils down to, in REST like endpoints, is not commong to have something like `/frameworks.json/UUID/tasks.json/UUID`. Marathon also has the endpoints: `/v2/apps/` and `/v2/apps/UUID/` which are not suffixed with json. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review70982 ----------------------------------------------------------- On Feb. 5, 2015, 1:54 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30612/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2015, 1:54 a.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-2157 > https://issues.apache.org/jira/browse/MESOS-2157 > > > Repository: mesos > > > Description > ------- > > Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}. > > Works with [29883](https://reviews.apache.org/r/29883). > > Builds on the abandoned patch 14286. > > > Diffs > ----- > > src/master/http.cpp 3981b18 > src/master/master.hpp cd37ee9 > src/master/master.cpp d04b2c4 > src/tests/master_tests.cpp 678d27f > > Diff: https://reviews.apache.org/r/30612/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
