----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review71636 -----------------------------------------------------------
Ship it! src/master/http.cpp <https://reviews.apache.org/r/30612/#comment117497> Maybe we should slightly reword this one to point out that the '/' is the separator. It was not clear to me when I read it first. // Creates a map where the keys are the slash separated pattern entries and the values... src/master/http.cpp <https://reviews.apache.org/r/30612/#comment117499> Add blank line to make it consistent with the above case. src/tests/master_tests.cpp <https://reviews.apache.org/r/30612/#comment117500> I think that '/' can be killed, not? src/tests/master_tests.cpp <https://reviews.apache.org/r/30612/#comment117501> We are adding two tasks, why not saying that in the comment? src/tests/master_tests.cpp <https://reviews.apache.org/r/30612/#comment117502> // Add two tasks to framework1. ? src/tests/master_tests.cpp <https://reviews.apache.org/r/30612/#comment117503> // ... "two tasks" ... src/tests/master_tests.cpp <https://reviews.apache.org/r/30612/#comment117504> s/asigned/assigned/g src/tests/master_tests.cpp <https://reviews.apache.org/r/30612/#comment117505> // ... "two tasks" ... ? src/tests/master_tests.cpp <https://reviews.apache.org/r/30612/#comment117506> Kill this line. - Till Toenshoff On Feb. 5, 2015, 12:54 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30612/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2015, 12:54 a.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-2157 > https://issues.apache.org/jira/browse/MESOS-2157 > > > Repository: mesos > > > Description > ------- > > Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}. > > Works with [29883](https://reviews.apache.org/r/29883). > > Builds on the abandoned patch 14286. > > > Diffs > ----- > > src/master/http.cpp 3981b18 > src/master/master.hpp cd37ee9 > src/master/master.cpp d04b2c4 > src/tests/master_tests.cpp 678d27f > > Diff: https://reviews.apache.org/r/30612/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
