----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29947/#review71946 -----------------------------------------------------------
I'm still scared by the double pointer.. Is there any other way? src/examples/test_hook_module.cpp <https://reviews.apache.org/r/29947/#comment117865> Why would this get called multiple times? src/tests/hook_tests.cpp <https://reviews.apache.org/r/29947/#comment117868> This whole promise lookup looks wrong to me. Is there any other way we can get the Promise/Future exposed through the module API? Maybe just add a "Future<something> executed()" or whatever? src/tests/hook_tests.cpp <https://reviews.apache.org/r/29947/#comment117866> Unnecessary. Times(1) is implicit. src/tests/hook_tests.cpp <https://reviews.apache.org/r/29947/#comment117867> Did you consider just sending an explicit ShutdownExecutorMessage from the slave to the executor? Then you can wait around for the hook to complete without worrying about the master/slave/framework shutting down in the meantime. - Adam B On Jan. 27, 2015, 4:39 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29947/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 4:39 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-2226 > https://issues.apache.org/jira/browse/MESOS-2226 > > > Repository: mesos > > > Description > ------- > > The task must be killed properly before shutting down the driver. > > > Diffs > ----- > > src/examples/test_hook_module.cpp 04fd43eb3eacae0d850dd7f4e191116d20620f10 > src/tests/hook_tests.cpp 44f73effdce2d03627215418007ccbc3263a0c52 > > Diff: https://reviews.apache.org/r/29947/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
