> On Feb. 11, 2015, 5:27 a.m., Adam B wrote:
> > I'm still scared by the double pointer.. Is there any other way?
Yup. We are thinking of using ("anonymous"?) libprocess events that would get
rid of the pointers entirely. Will update the diffs once the work is done.
> On Feb. 11, 2015, 5:27 a.m., Adam B wrote:
> > src/examples/test_hook_module.cpp, line 120
> > <https://reviews.apache.org/r/29947/diff/7/?file=837750#file837750line120>
> >
> > Why would this get called multiple times?
If for example, someone writes a test case that installs all hooks but verifies
only a subset of them. However, this concern would be mitigated once we use
libprocess events.
> On Feb. 11, 2015, 5:27 a.m., Adam B wrote:
> > src/tests/hook_tests.cpp, line 94
> > <https://reviews.apache.org/r/29947/diff/7/?file=837751#file837751line94>
> >
> > This whole promise lookup looks wrong to me. Is there any other way we
> > can get the Promise/Future exposed through the module API? Maybe just add a
> > "Future<something> executed()" or whatever?
Should not be a concern (see above).
- Kapil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29947/#review71946
-----------------------------------------------------------
On Jan. 27, 2015, 7:39 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29947/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2015, 7:39 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-2226
> https://issues.apache.org/jira/browse/MESOS-2226
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The task must be killed properly before shutting down the driver.
>
>
> Diffs
> -----
>
> src/examples/test_hook_module.cpp 04fd43eb3eacae0d850dd7f4e191116d20620f10
> src/tests/hook_tests.cpp 44f73effdce2d03627215418007ccbc3263a0c52
>
> Diff: https://reviews.apache.org/r/29947/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Kapil Arya
>
>
