> On Feb. 12, 2015, 9:55 a.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 262 > > <https://reviews.apache.org/r/29288/diff/19-20/?file=860854#file860854line262> > > > > these memset calls are redundant (and dangerous should the storage ever > > become a struct/class). > > Evelina Dumitrescu wrote: > I do this because I use memcmp for comparisions.
maybe explicit family + addr checks are going to be better. they'll be faster than memcmp too, i imagine. > On Feb. 12, 2015, 9:55 a.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 300 > > <https://reviews.apache.org/r/29288/diff/19-20/?file=860854#file860854line300> > > > > AF_UNSPEC? > > Evelina Dumitrescu wrote: > In the code we check only against AF_INET and AF_INET6. For AF_UNSPEC an > Error will be returned. how often do we create an IP without specifying address/family? it might be ok to not have the default constructor. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29288/#review72194 ----------------------------------------------------------- On Feb. 12, 2015, 9:47 a.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29288/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2015, 9:47 a.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van > Remoortere, and Niklas Nielsen. > > > Bugs: MESOS-1919 > https://issues.apache.org/jira/browse/MESOS-1919 > > > Repository: mesos > > > Description > ------- > > Created the inner class InAddrStorage encapsulated inside the IP class. > The class uses a union with the in_addr and in6_addr fields. > I considered that the The MasterInfo protobuffers should have both an ipv4 > and an ipv6 field. > I intend to use the same Classifiers, addition, removal and update of > container filters, but write different encode/decode functions for IPv4/ICMP > and IPv6/ICMPv6 because the processing of the protocol headers differ. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > a0210ea6440086246aafe632f86498abbb70719a > 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp > 425132e5d7c3770be4a5a39feea5a2f22179b871 > > Diff: https://reviews.apache.org/r/29288/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
