> On Feb. 16, 2015, 6:28 p.m., Jie Yu wrote: > > src/slave/containerizer/linux_launcher.cpp, line 357 > > <https://reviews.apache.org/r/30906/diff/3/?file=863791#file863791line357> > > > > Any reason not place this metrics at top level (i.e., in > > `MesosContainerizerProcess::__destroy`)? In that way, you don't need to do > > `++metrics.destroy_error` multiple times, thoughts?
Launcher class seemed like the right place to hold launcher related metrics. Incrementing the counter in MesosContainerizerProcess seemed weird / breaking the abstraction. Also, note that this is a linux launcher only metric for now. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30906/#review72639 ----------------------------------------------------------- On Feb. 13, 2015, 10:37 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30906/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2015, 10:37 p.m.) > > > Review request for mesos, Ian Downes and Jie Yu. > > > Bugs: MESOS-1690 > https://issues.apache.org/jira/browse/MESOS-1690 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am d372404d84c9ac0bc49da7407ad366701b9586a6 > src/slave/containerizer/linux_launcher.hpp > 37304222323d3089b95df605d2077a3f88d11277 > src/slave/containerizer/linux_launcher.cpp > 3fdfb5709d48d079bbe904a91b773f131131b08d > src/slave/containerizer/mesos/containerizer.cpp > d5b90d12d63becfeb4c3efa9c6f5d826417f582c > src/tests/launcher_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/30906/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
