> On Feb. 24, 2015, 7:19 p.m., Jie Yu wrote: > > src/tests/containerizer_tests.cpp, line 475 > > <https://reviews.apache.org/r/30906/diff/5/?file=874160#file874160line475> > > > > Checking metrics?
oops :/ > On Feb. 24, 2015, 7:19 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 908-918 > > <https://reviews.apache.org/r/30906/diff/5/?file=874159#file874159line908> > > > > Looks like this is a regression introduced in > > https://reviews.apache.org/r/28141/ > > > > I made a comment there and created a ticket: > > https://issues.apache.org/jira/browse/MESOS-2398 ty. > On Feb. 24, 2015, 7:19 p.m., Jie Yu wrote: > > src/tests/containerizer_tests.cpp, lines 416-422 > > <https://reviews.apache.org/r/30906/diff/5/?file=874160#file874160line416> > > > > Can you pull that into src/tests/launcher.hpp? I think this particular action is very specific to this test. So didn't want to pollute the generic tests/launcher.hpp. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30906/#review73836 ----------------------------------------------------------- On Feb. 24, 2015, 8:04 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30906/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2015, 8:04 p.m.) > > > Review request for mesos, Ian Downes and Jie Yu. > > > Bugs: MESOS-1690 > https://issues.apache.org/jira/browse/MESOS-1690 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > d4fc8c8fdb94c470892e73ae08796b620b74d17b > src/slave/containerizer/mesos/containerizer.cpp > a587ed38b1df9ef489b4a1b5eb7f16c34d89d156 > src/tests/containerizer_tests.cpp d96a3a8955cb85c6b710c246fc23cb3aa5134920 > src/tests/mesos.hpp e17afe74796ffe148274e278b5fa574e5c1bd34c > > Diff: https://reviews.apache.org/r/30906/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
