----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30339/#review72915 -----------------------------------------------------------
Ship it! src/tests/hook_tests.cpp <https://reviews.apache.org/r/30339/#comment119027> Sharp bracket closing; that part somehow slipped through the recent "hooks" commits - there are more of those in these tests. Worth a small followup-patch? - Till Toenshoff On Jan. 28, 2015, 12:42 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30339/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2015, 12:42 a.m.) > > > Review request for mesos, Niklas Nielsen and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Call hook manager only if hooks were specified on the commandline. > > > Diffs > ----- > > src/master/master.cpp bda8fda9bc2e52ccc1d75e2541e4604989515e13 > src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 > src/slave/slave.cpp fca83b3977b95ddda30f9830da10e124b5c605e6 > src/tests/hook_tests.cpp 44f73effdce2d03627215418007ccbc3263a0c52 > > Diff: https://reviews.apache.org/r/30339/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
