----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30339/#review72824 -----------------------------------------------------------
src/slave/slave.hpp <https://reviews.apache.org/r/30339/#comment118916> Can you split this into it's own commit or document it in the review request description? src/slave/slave.cpp <https://reviews.apache.org/r/30339/#comment122235> Needs 2 space indent extra. src/tests/hook_tests.cpp <https://reviews.apache.org/r/30339/#comment122232> s/> >/>>/g src/tests/hook_tests.cpp <https://reviews.apache.org/r/30339/#comment122233> Where does this constant come from? Should we perhaps move this into CreateMasterFlags()? src/tests/hook_tests.cpp <https://reviews.apache.org/r/30339/#comment122234> Same here. - Niklas Nielsen On Jan. 27, 2015, 4:42 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30339/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 4:42 p.m.) > > > Review request for mesos, Niklas Nielsen and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Call hook manager only if hooks were specified on the commandline. > > > Diffs > ----- > > src/master/master.cpp bda8fda9bc2e52ccc1d75e2541e4604989515e13 > src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 > src/slave/slave.cpp fca83b3977b95ddda30f9830da10e124b5c605e6 > src/tests/hook_tests.cpp 44f73effdce2d03627215418007ccbc3263a0c52 > > Diff: https://reviews.apache.org/r/30339/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
