----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31125/#review72922 -----------------------------------------------------------
src/docker/docker.cpp <https://reviews.apache.org/r/31125/#comment119033> space betwen if ( src/docker/docker.cpp <https://reviews.apache.org/r/31125/#comment119034> Can you leave a comment on the code why you're adding this? src/docker/docker.cpp <https://reviews.apache.org/r/31125/#comment119035> This is no longer relevant comment right? src/docker/docker.cpp <https://reviews.apache.org/r/31125/#comment119036> Perhaps an example to proof the point? src/docker/docker.cpp <https://reviews.apache.org/r/31125/#comment119038> Comments in Mesos can't exceed 70 char width. src/docker/docker.cpp <https://reviews.apache.org/r/31125/#comment119037> typo -> truncated src/docker/docker.cpp <https://reviews.apache.org/r/31125/#comment119039> Why not just strings::split(header, " ")? src/docker/docker.cpp <https://reviews.apache.org/r/31125/#comment119040> This seems too excessive to log at VLOG(1) level. src/docker/docker.cpp <https://reviews.apache.org/r/31125/#comment119041> This seems to low of a level, VLOG(2)? src/docker/docker.cpp <https://reviews.apache.org/r/31125/#comment119042> Why spending all this work to just get the name? From the nameIdx (and perhaps also a nameEndIdx, can't we) can't' we just get the name directly out of the line? - Timothy Chen On Feb. 17, 2015, 11:52 p.m., Henning Schmiedehausen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31125/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2015, 11:52 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-2357 > https://issues.apache.org/jira/browse/MESOS-2357 > > > Repository: mesos > > > Description > ------- > > Parse the docker ps format correctly (identify the columns by the > header names), then find the NAMES column for the container names and > parse container names out. > > This ensures that, when docker adds more columns to the ps output, > the parsing will not break. > > Also issue the --no-trunc command line option to have the output > columns not truncated by docker. > > > Diffs > ----- > > src/docker/docker.cpp 94f16e701f89367b599f0bd8f44c2f1de21a8e20 > > Diff: https://reviews.apache.org/r/31125/diff/ > > > Testing > ------- > > > Thanks, > > Henning Schmiedehausen > >
