> On Feb. 18, 2015, 12:21 a.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 764 > > <https://reviews.apache.org/r/31125/diff/1/?file=866409#file866409line764> > > > > This is no longer relevant comment right?
the line moved but the comment did not. > On Feb. 18, 2015, 12:21 a.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 767 > > <https://reviews.apache.org/r/31125/diff/1/?file=866409#file866409line767> > > > > Perhaps an example to proof the point? would love to but it will not fit the "Comments in Mesos can't exceed 70 char width" restraint. - Henning ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31125/#review72922 ----------------------------------------------------------- On Feb. 17, 2015, 3:52 p.m., Henning Schmiedehausen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31125/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2015, 3:52 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-2357 > https://issues.apache.org/jira/browse/MESOS-2357 > > > Repository: mesos > > > Description > ------- > > Parse the docker ps format correctly (identify the columns by the > header names), then find the NAMES column for the container names and > parse container names out. > > This ensures that, when docker adds more columns to the ps output, > the parsing will not break. > > Also issue the --no-trunc command line option to have the output > columns not truncated by docker. > > > Diffs > ----- > > src/docker/docker.cpp 94f16e701f89367b599f0bd8f44c2f1de21a8e20 > > Diff: https://reviews.apache.org/r/31125/diff/ > > > Testing > ------- > > > Thanks, > > Henning Schmiedehausen > >
