> On Feb. 18, 2015, 12:22 a.m., Timothy Chen wrote: > > Do we have test for this?
No. If you look at tests/net.cpp you will find that we don't have any tests whatsoever for anything in net:: that involve any network traffic. I suppose this is so because it is so much easier to write these against these functions once you have libprocess! Furthermore they get excercised by Mesos tests. This particular function is tested daily by fetcher cache tests which are under review. - Bernd ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30606/#review72923 ----------------------------------------------------------- On Feb. 18, 2015, 12:01 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30606/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 12:01 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and > Timothy Chen. > > > Bugs: MESOS-2072 > https://issues.apache.org/jira/browse/MESOS-2072 > > > Repository: mesos > > > Description > ------- > > Adds net::contentLength(). This makes a short HTTP request to read the > "content-length" field from the HTTP header. > > This will be used to determine the size of a file before downloading it to > the fetcher cache, in order to ensure there is enough space ahead of time. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > b464e517bb1e7b6b381c6cd6c0466ed788a82615 > > Diff: https://reviews.apache.org/r/30606/diff/ > > > Testing > ------- > > Used this function in the context of my implementation of MESOS-2072 and > MESOS-2074. It correctly reported the content length from an HTTP server > constructed from libprocess primitives. > > > Thanks, > > Bernd Mathiske > >
