----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30606/#review74445 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/30606/#comment121015> Just like Nikita, I think it really makes sense to add a comment here, hinting that the returned value may actually be entirely bogus. See http://curl.haxx.se/mail/lib-2003-06/0146.html - Till Toenshoff On Feb. 27, 2015, 2:33 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30606/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2015, 2:33 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and > Timothy Chen. > > > Bugs: MESOS-2072 > https://issues.apache.org/jira/browse/MESOS-2072 > > > Repository: mesos > > > Description > ------- > > Adds net::contentLength(). This makes a short HTTP request to read the > "content-length" field from the HTTP header. > > This will be used to determine the size of a file before downloading it to > the fetcher cache, in order to ensure there is enough space ahead of time. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > 9635bbc6f7dae1d75a780069fcc60fb706221053 > > Diff: https://reviews.apache.org/r/30606/diff/ > > > Testing > ------- > > Used this function in the context of my implementation of MESOS-2072 and > MESOS-2074. It correctly reported the content length from an HTTP server > constructed from libprocess primitives. > > > Thanks, > > Bernd Mathiske > >
