----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31028/#review73215 -----------------------------------------------------------
src/examples/test_hook_module.cpp <https://reviews.apache.org/r/31028/#comment119457> Should be `Label* label`. src/tests/hook_tests.cpp <https://reviews.apache.org/r/31028/#comment119462> `s/> >/>>/` here and below. src/tests/hook_tests.cpp <https://reviews.apache.org/r/31028/#comment119463> `.Times(1)` can be omitted here and below. src/tests/hook_tests.cpp <https://reviews.apache.org/r/31028/#comment119459> `ASSERT_EQ(1, offers.get().size())` - Michael Park On Feb. 13, 2015, 11:28 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31028/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2015, 11:28 p.m.) > > > Review request for mesos, Ben Mahler and Kapil Arya. > > > Repository: mesos > > > Description > ------- > > See summary > > > Diffs > ----- > > src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d > src/tests/hook_tests.cpp dc6d289394e5718a37936e29ad6d988b52933f98 > > Diff: https://reviews.apache.org/r/31028/diff/ > > > Testing > ------- > > make check (with newly added VerifySlaveRunTaskHook test) > > > Thanks, > > Niklas Nielsen > >
