> On Feb. 21, 2015, 1:27 a.m., Jie Yu wrote:
> > src/linux/cgroups.cpp, lines 2279-2280
> > <https://reviews.apache.org/r/30545/diff/6/?file=871037#file871037line2279>
> >
> >     I think here should be able to do:
> >     ```
> >       : coutner_(0),
> >         error(None()),
> >         process(new event::Listener(
> >             hierarchy,
> >             cgroup,
> >             "memory.pressure_level",
> >             stringify(level))) {}
> >     ```

hmm.. it does compile, but doesn't the constructor for process take an 
'explicit' argument?


- Chi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30545/#review73359
-----------------------------------------------------------


On Feb. 22, 2015, 5:13 a.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30545/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2015, 5:13 a.m.)
> 
> 
> Review request for mesos, Dominic Hamon, Ian Downes, and Jie Yu.
> 
> 
> Bugs: MESOS-2136
>     https://issues.apache.org/jira/browse/MESOS-2136
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> cgroups: added support to listen on memory pressures.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp e07772fec11b9bb73a44c54326f24d7ee1e8a64b 
>   src/linux/cgroups.cpp a307e27c5840270e28cced2d5aeb90c6679bff1d 
> 
> Diff: https://reviews.apache.org/r/30545/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Reply via email to