----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30545/#review73585 -----------------------------------------------------------
src/linux/cgroups.hpp <https://reviews.apache.org/r/30545/#comment119980> you already forward declared this above... didn't you? is there an event::Listener and a pressure::Listener? not that you need this forward declaration... you declare the class two lines later. src/linux/cgroups.cpp <https://reviews.apache.org/r/30545/#comment119981> thank you for using Owned! src/linux/cgroups.cpp <https://reviews.apache.org/r/30545/#comment119982> maybe CHECK_NOTNULL(process.get()) in case someone is trying to call counter during Listener destruction? - Dominic Hamon On Feb. 22, 2015, 8:43 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30545/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2015, 8:43 p.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2136 > https://issues.apache.org/jira/browse/MESOS-2136 > > > Repository: mesos > > > Description > ------- > > cgroups: added support to listen on memory pressures. > > > Diffs > ----- > > src/linux/cgroups.hpp e07772fec11b9bb73a44c54326f24d7ee1e8a64b > src/linux/cgroups.cpp a307e27c5840270e28cced2d5aeb90c6679bff1d > > Diff: https://reviews.apache.org/r/30545/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
