----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31246/#review73560 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/31246/#comment119955> We are basically counting set bits here. Cannot we do better than iterating over each bit? - Alexander Rojas On Feb. 21, 2015, 4:21 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31246/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2015, 4:21 p.m.) > > > Review request for mesos and Dominic Hamon. > > > Repository: mesos > > > Description > ------- > > stout: Extend the IP class to support IPv6 and renamed > net::IP::fromDotDecimal to net::IP::parse > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > b464e517bb1e7b6b381c6cd6c0466ed788a82615 > 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp > 425132e5d7c3770be4a5a39feea5a2f22179b871 > > Diff: https://reviews.apache.org/r/31246/diff/ > > > Testing > ------- > > > Thanks, > > Evelina Dumitrescu > >
