> On Feb. 23, 2015, 2:11 p.m., Alexander Rojas wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, lines 366-368 > > <https://reviews.apache.org/r/31246/diff/2/?file=871696#file871696line366> > > > > We are basically counting set bits here. Cannot we do better than > > iterating over each bit?
Thank you for pointing me out the idea. Implemented on review 29288. - Evelina ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31246/#review73560 ----------------------------------------------------------- On Feb. 21, 2015, 3:21 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31246/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2015, 3:21 p.m.) > > > Review request for mesos and Dominic Hamon. > > > Repository: mesos > > > Description > ------- > > stout: Extend the IP class to support IPv6 and renamed > net::IP::fromDotDecimal to net::IP::parse > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > b464e517bb1e7b6b381c6cd6c0466ed788a82615 > 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp > 425132e5d7c3770be4a5a39feea5a2f22179b871 > > Diff: https://reviews.apache.org/r/31246/diff/ > > > Testing > ------- > > > Thanks, > > Evelina Dumitrescu > >
